[PATCH] D107262: [CodeGenPrepare] The instruction to be sunk should be inserted before its user in a block

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added a comment.

In D107262#2941680 <https://reviews.llvm.org/D107262#2941680>, @dmgreen wrote:

> Yeah, this sounds good to me. I might have used `std::distance(TargetBB->begin(), UI) < std::distance(TargetBB->begin(), InsertPt)` myself, as there will only even be a few sinking nodes and they may not be in the TargetDB, but your way with collecting the block sounds good too.
>
> LGTM

Why not ‘comesBefore’ ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107262/new/

https://reviews.llvm.org/D107262