[PATCH] D107968: [llvm-readobj] Refactor ELFDumper::printAttributes()

[Jozef Lawrynowicz via Phabricator via llvm-commits]

jozefl added a comment.

In D107968#2948901 <https://reviews.llvm.org/D107968#2948901>, @jhenderson wrote:

> In D107968#2948883 <https://reviews.llvm.org/D107968#2948883>, @jozefl wrote:
>
>> Ah yes that makes sense. My mistake was assuming there were other targets with
>> unimplemented ELF attribute support when in fact, MSP430 is the only one.
>
> I wouldn't assume that there aren't others, but at this point, we can't know which machine kinds might still be missing an implementation, so we can't really warn for them.

I checked the source of binutils-readelf, and for the targets that LLVM supports, llvm-readelf has parity with it in terms of the targets that it will dump a target-specific attribute section for.
However, binutils-readelf also handles SHT_GNU_ATTRIBUTES, which can be used with any target.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107968/new/

https://reviews.llvm.org/D107968