[PATCH] D106942: Consider section flags when adding section

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 02:20:33 PDT 2021


jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/set-flags-on-setion-added.test:13
+# CHECK-NEXT:  RawDataSize: 9
+# CHECK:       Characteristics [ (0xE0000020)
+# CHECK-NEXT:      IMAGE_SCN_CNT_CODE (0x20)
----------------
I'd omit the `(0x...)` bit from this line and the similar line below. This will a) make maintaining the test easier in the future (if the flag set changes), and more importantly b) will ensure this matches the Characteristics block for this section as opposed to some future section.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106942/new/

https://reviews.llvm.org/D106942



More information about the llvm-commits mailing list