[PATCH] D108097: [llvm-objdump] -T: print symbol versions

Tue Aug 17 01:01:07 PDT 2021

MaskRay added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/ELF/dynsym-version.test:101
+
+## Test the output with a long version name.
+# RUN: yaml2obj --docnum=2 -DINDEX=1 %s -o %t2
----------------
jhenderson wrote:
> Up to you whether you do this, but I see no harm in folding it in with the main case. This helps reduce the number of individual test cases.
If in the future we ever compute the max width of the section & the version name, having separate tests can test the case when all version names are not greater than 12 bytes.

Using `[[VERSION_NAME=v5hidden]]` is an alternative, but that may make the test a bit complex.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108097/new/

https://reviews.llvm.org/D108097