[PATCH] D108097: [llvm-objdump] -T: print symbol versions

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/dynsym-version.test:101
+
+## Test the output with a long version name.
+# RUN: yaml2obj --docnum=2 -DINDEX=1 %s -o %t2
----------------
Up to you whether you do this, but I see no harm in folding it in with the main case. This helps reduce the number of individual test cases.


================
Comment at: llvm/test/tools/llvm-objdump/ELF/dynsym-version.test:102
+## Test the output with a long version name.
+# RUN: yaml2obj --docnum=2 -DINDEX=1 %s -o %t2
+# RUN: llvm-objdump -T %t2 2>&1 | tr '\t' '|' | FileCheck %s \
----------------
If you choose not to merge things, I think you can drop the `-DINDEX=1` right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108097/new/

https://reviews.llvm.org/D108097