[PATCH] D108008: [WIP][Attributor] AAHotCold Use CFG to propagate hot cold.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:9747
+    }
+
     return Change;
----------------
I don't like the true => hot, false = cold encoding. We should make it explicit.

How does the backwards traversal change anything here? I can see how it might if we do more in `Propagate`.
Also, we should not walk the CFG twice. WDYT about one of the following two:
1) Keep a list of blocks for which we actually want to know hot/cold information. We want to know if there is a call site for which we want to know, and then transitively other blocks around if possible, or
2) Expand from known information. So we use some sources of hotness and only look at the blocks for which we have a hot/cold annotation and try to add more to the set.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108008/new/

https://reviews.llvm.org/D108008