[PATCH] D108162: AMDGPU: Optimize amdgpu-no-* attributes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert resigned from this revision.
jdoerfert added a comment.

Not qualified to look at the ISel and other AMDGPU parts, one comment though.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp:805
+    if (Info.CB->hasFnAttr(ImplicitAttrNames[I++]))
+      continue;
+
----------------
Can we merge inputregs and impliciAttrNames into one array of structs so there is a proper one to one mapping, this is very implicit and harder to understand.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108162/new/

https://reviews.llvm.org/D108162