[PATCH] D108158: AMDGPU: Invert AMDGPUAttributor

Kuter Dinel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 14:35:59 PDT 2021


kuter added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:365
+        // If the callee needs an input, we need it too.
+        for (unsigned I = 0; I != NUM_IMPLICIT_ARGUMENTS; ++I) {
+          if (!AAAMD.isAssumed(1 << I)) {
----------------
Rather then doing this we can use `BitIntegerState::joinAND()`or rahter `IntegerBaseState::operator&=()` which calls `joinAND()` internally.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108158/new/

https://reviews.llvm.org/D108158



More information about the llvm-commits mailing list