[PATCH] D108098: [cmake] properly support target_link_directories and target_include_directories

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D108098#2945907 <https://reviews.llvm.org/D108098#2945907>, @stellaraccident wrote:

> Read my mind - was meaning to do this very change last week but ran out of time. How much further are you going? I'd ultimately like our targets to all have proper include/link directories defined so we don't need to do so much global munging.

I'm not necessarily doing more with this.. mostly trying to help Uday :)

> I also frequently run into the problem that when object libraries are involved, you can only set compile flags on the object library, but that requires knowing whether an object library was used to define the target. It makes writing generic utilities brittle - and worse: in MLIR we often decide to use an object library or not based on what link mode is in use (and if not xcode). I haven't quite convinced myself that this forwarding trick is the right thing for such cases.

Yeah, I definitely don't think it's the right thing to blindly forward *ALL* the myriad target properties.  But I convinced myself that at least in the short term this was the right thing to do small...  Let's start by expanding your handling of shared libraries to libMLIR.so, then we can see how it can be used to cleanup the bigger LLVM issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108098/new/

https://reviews.llvm.org/D108098