[PATCH] D108130: [flang][nfc] Tweak the FrontendAction class

[Asher Mancinelli via Phabricator via llvm-commits]

ashermancinelli added inline comments.


================
Comment at: flang/lib/Frontend/FrontendAction.cpp:159
+
+bool FrontendAction::RunSema() {
+  CompilerInstance &ci = this->instance();
----------------
awarzynski wrote:
> ashermancinelli wrote:
> > [nit] Would it be too invasive to expand this name in this patch, eg `RunSemanticAction` or something else more verbose?
> `RunSema` is a poor name, thanks for complaining :)
> 
> I'd rather avoid using `Action` here as this method does not correspond to a particular `FrontendAction`. Instead, it will be used by multiple specialisations of that class. Let me rename it as `RunSemanticChecks`. 
Looks great!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108130/new/

https://reviews.llvm.org/D108130