[PATCH] D107089: [flang][driver] Add print function name Plugin example

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 10:27:26 PDT 2021


kiranchandramohan added a comment.

LGTM. I have one comment.



================
Comment at: flang/examples/PrintFlangFunctionNames/PrintFlangFunctionNames.cpp:60
+    void Post(const Fortran::parser::MpSubprogramStmt &m) {
+      llvm::outs() << "ModuleProcedure: " << (m.v).ToString() << "\n";
+    }
----------------
Nit: Do you want to count this along with Subroutines or as a separate category?  If you are not counting then it might be OK to skip it completely.

There are also statement functions. How will you count them? If not counting then feel free to skip.
https://docs.oracle.com/cd/E19957-01/805-4939/6j4m0vnb9/index.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107089/new/

https://reviews.llvm.org/D107089



More information about the llvm-commits mailing list