[PATCH] D108016: [lld-macho] Ignore LLVM segments to prevent duplicate syms

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/test/MachO/discard-llvm-sections.s:6
+
+## _llvm. symbols are not special. LLD would produce duplicate symbol errors
+## if they were not within the LLVM segment.
----------------
nit


================
Comment at: lld/test/MachO/discard-llvm-sections.s:18
+# CHECK-NEXT:  Idx  Name    Size      VMA               Type
+# CHECK-NEXT:  0    __text  00000000 00000000000002a8   TEXT
+
----------------
looks like the windows test is failing as the address is slightly different there. We should probably figure out why at some point, but since it's not really important to this test we can just match any hex value


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108016/new/

https://reviews.llvm.org/D108016