[PATCH] D108073: [PassBuilder] Don't use MemorySSA for standalone LoopRotate passes

Mon Aug 16 09:48:02 PDT 2021

asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

In D108073#2945148 <https://reviews.llvm.org/D108073#2945148>, @nikic wrote:

>> Weirdly, I'm not seeing any significant compile-time change from this patch, so I'm wondering if I'm misunderstanding something here...
>
> The answer to that is D108074 <https://reviews.llvm.org/D108074>: There are subsequent passes that also have unnecessary MemorySSA requirements, so just dropping it here doesn't matter much in practice.

Makes sense. I'm happy to drop these. They can always be readded if those passes are changed to use (and preserve) MemorySSA.
Thank you for the cleanup patches!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108073/new/

https://reviews.llvm.org/D108073