[PATCH] D107087: Fix SectionMemoryManager deconstruction error with MSVC

Justice Adams via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 09:38:20 PDT 2021


justice_adams added a comment.

@lhames You are correct! I wasn't familiar with `ManagedStatic` but that does fix it. Do you prefer that approach to what's here? If so, I'll go ahead and update the diff. Originally I thought it made sense to have `DefaultMMapperInstance` be an instance variable of the `SectionMemoryManager` since it's the only place it's used, but perhaps not since I would have to move the corresponding class definition into the `SectionMemoryManager` as I did here


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107087/new/

https://reviews.llvm.org/D107087



More information about the llvm-commits mailing list