[PATCH] D108143: [DebugInfo][InstrRef] Correctly ignore DBG_VALUE_LIST in InstrRef mode, for now

[Jeremy Morse via Phabricator via llvm-commits]

jmorse created this revision.
jmorse added reviewers: StephenTozer, Orlando, TWeaver.
Herald added a subscriber: hiraditya.
jmorse requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch makes InstrRefBasedLDV "safe" to work with DBG_VALUE_LISTs. It doesn't actually interpret them, but it recognises that they specify variable locations and avoids propagating false locations, which is better than the current state. Observe the attached test:

- We avoid propagating DBG_VALUE_LISTs into successor blocks, as they're not "currently" supported,
- We don't propagate other variable locations across DBG_VALUE_LISTs, because we know that the variable location is terminated by the DBG_VALUE_LIST.

I'd like to get this patch into the llvm-13 branch, so that anyone experimenting with this in the meantime gets safe variable locations. Then we can get on to properly supporting DBG_VALUE_LISTs.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108143

Files:
  llvm/lib/CodeGen/LiveDebugValues/InstrRefBasedImpl.cpp
  llvm/test/DebugInfo/MIR/InstrRef/ignore-dbg-value-list.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108143.366657.patch
Type: text/x-patch
Size: 4058 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210816/4f5f3f0b/attachment.bin>