[PATCH] D73426: [Attributor] Derive memory location attributes (argmemonly, ...)

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

> With a loss of the store in the caller. So, is this a bug in the attributor, because it is marking the callee "readnone"? Or is it a bug in dse, because it thinks that 'readnone' with a byval arg menas it can eleiminate the store in the caller?

This is a good point. Initially, I was hoping byval arguments would be owned by the callee, however, as of right now they are not. Even if we conceptually let them be owned by the callee, we would need some changes in various places to account for the explicit copy while retaining the `readnone` the attributor adds. Long story short, this is (right now) a bug and should be fixed. I made D108140 <https://reviews.llvm.org/D108140> which also contains a TODO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73426/new/

https://reviews.llvm.org/D73426