[PATCH] D107544: [X86] [AMX] Replace bitcast with specific AMX intrinsics with X86 specific cast.

Bing Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 07:57:10 PDT 2021


yubing added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:71
+  Value *Vec;
+  if (match(II,
+            m_Intrinsic<Intrinsic::x86_cast_vector_to_tile>(m_Value(Vec))) ||
----------------
fhahn wrote:
> can you just `return match() || match()`?
> 
> Also it looks like you are not using `Vec`, so you could use `m_Any()` or something like that instead.
Thanks for comments. You're right, I will change it.
We could use m_Value().


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107544/new/

https://reviews.llvm.org/D107544



More information about the llvm-commits mailing list