[PATCH] D108130: [flang][nfc] Tweak the FrontendAction class

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 07:38:39 PDT 2021


awarzynski created this revision.
awarzynski requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This patch refactors the `FrontendAction` class. It merely moves code
around so that re-using it is easier. No new functionality is
introduced.

1. Three new member methods are introduced: `RunPrescan`, `RunParse`,

`RunSema`.

2. The following free functions are re-implemented as member methods:
  - `reportFatalSemanticErrors`
  - `reportFatalScanningErrors`
  - `reportFatalParsingErrors`
  - `reportFatalErrors`

`reportFatalSemanticErrors` is updated to resemble the other error
reporting functions and to make the API more consistent.

3. The `BeginSourceFileAction` methods are simplified and the unused

input argument is deleted.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108130

Files:
  flang/include/flang/Frontend/FrontendAction.h
  flang/include/flang/Frontend/FrontendActions.h
  flang/lib/Frontend/FrontendAction.cpp
  flang/lib/Frontend/FrontendActions.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108130.366626.patch
Type: text/x-patch
Size: 15273 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210816/ece343c6/attachment.bin>


More information about the llvm-commits mailing list