[PATCH] D107580: [VectorCombine] Support AND/UREM indices that require freezing.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 06:20:39 PDT 2021


fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:810
+           "should only be used when freezing is required");
+    for (Use &U : make_early_inc_range((ToFreeze)->uses()))
+      if (U.getUser() == &User) {
----------------
lebedev.ri wrote:
> lebedev.ri wrote:
> > 
> Why do you have to go through all the uses of `ToFreeze`, even though you only want to fix `User`?
> Can't you just go through the operands of `User`?
> Can't you just go through the operands of User?

For the current version of the API yes! Updated, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107580/new/

https://reviews.llvm.org/D107580



More information about the llvm-commits mailing list