[PATCH] D107968: [llvm-readobj] Refactor ELFDumper::printAttributes()

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:2592
+  std::unique_ptr<ELFAttributeParser> AttrParser;
+  switch (Obj.getHeader().e_machine) {
+  case EM_ARM:
----------------
I'm mildly uncomfortable that there is an overlap between this switch statement and that contained in `printArchSpecificInfo` - you'd need to update both switch statements to access this code. I wonder if you could change `printAttributes` to take the parser and required section type as an input argument and create it in the appropriate place in `printArchSpecificInfo` instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107968/new/

https://reviews.llvm.org/D107968