[llvm] febcedf - Revert "[NFCI][IndVars] rewriteLoopExitValues(): nowadays SCEV should not change `GEP` base pointer"

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 04:30:59 PDT 2021


Author: Roman Lebedev
Date: 2021-08-16T14:30:29+03:00
New Revision: febcedf18c75c603d6336b2373dcd6f01bc8028d

URL: https://github.com/llvm/llvm-project/commit/febcedf18c75c603d6336b2373dcd6f01bc8028d
DIFF: https://github.com/llvm/llvm-project/commit/febcedf18c75c603d6336b2373dcd6f01bc8028d.diff

LOG: Revert "[NFCI][IndVars] rewriteLoopExitValues(): nowadays SCEV should not change `GEP` base pointer"

https://bugs.llvm.org/show_bug.cgi?id=51490 was filed.

This reverts commit 35a8bdc775817ce13a6c9b5cf81502052634aa1f.

Added: 
    

Modified: 
    llvm/lib/Transforms/Utils/LoopUtils.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Utils/LoopUtils.cpp b/llvm/lib/Transforms/Utils/LoopUtils.cpp
index 49dbb0439d31c..661b99f112117 100644
--- a/llvm/lib/Transforms/Utils/LoopUtils.cpp
+++ b/llvm/lib/Transforms/Utils/LoopUtils.cpp
@@ -1346,9 +1346,6 @@ int llvm::rewriteLoopExitValues(Loop *L, LoopInfo *LI, TargetLibraryInfo *TLI,
 
     // FIXME: isValidRewrite() is a hack. it should be an assert, eventually.
     Phi.ValidRewrite = isValidRewrite(SE, Phi.ExpansionPoint, Phi.Expansion);
-    assert(Phi.ValidRewrite &&
-           "Now that the SCEV is strict wrt pointer/integer types, this "
-           "invariant is expected to be uphold by SCEV itself.");
     if (!Phi.ValidRewrite) {
       DeadInsts.push_back(Phi.Expansion);
       continue;


        


More information about the llvm-commits mailing list