[PATCH] D107949: [llvm-objdump/llvm-readobj/obj2yaml/yaml2obj] Support STO_RISCV_VARIANT_CC and DT_RISCV_VARIANT_CC

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 04:10:45 PDT 2021


jhenderson added a comment.

Looks like there are two separate features being added here at once. Shouldn't they be each in their own patch?

Also, I think you can delete `a.o`?



================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1617
+static const EnumEntry<unsigned> ElfRISCVSymOtherFlags[] = {
+  LLVM_READOBJ_ENUM_ENT(ELF, STO_RISCV_VARIANT_CC)
+};
----------------
clang-format is complaining here for some reason.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107949/new/

https://reviews.llvm.org/D107949



More information about the llvm-commits mailing list