[PATCH] D106643: [llvm-readobj][XCOFF] Add support for `--needed-libs` option.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I like the new output format better. That being said, I think you need to be careful of really long filenames. I don't know what's the best approach here, but one option would be to parse all the names before printing the headers, and then adjust the column widths accordingly. Up to you though.



================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/needed-libs.test:10
+#      CHECK:NeededLibraries [
+# CHECK-NEXT:  PATH           BASE           MEMBER         
+# CHECK-NEXT:                 libc.a         shr.o          
----------------
If the PATH column is always empty, then there's no point in having it in the header. If it isn't, we need a test case showing that things can be printed in this field.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106643/new/

https://reviews.llvm.org/D106643