[PATCH] D100808: Use Propeller ID instead of MBB IDs.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

CodeGen isn't really my thing, so I can't really review that side of things. The dumping/yaml2obj etc changes all seem fine, assuming the proposal as a whole is acceptable.

One thought I had: I was (perhaps incorrectly) under the impression that Propeller is something external to LLVM. It seems a bit backwards to be referring to it by name throughout this change, via code comments and variable names etc. Would it make more sense to use simply "ID" or something like "FixedID" or similar?



================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:165
 
+  /// Propeller ID assigned to this basic block. used with basic block sections
+  /// and basic block labels.
----------------



================
Comment at: llvm/lib/CodeGen/MIRParser/MIParser.cpp:667
 
+// Parse Machine Basic Block Propeller ID
+bool MIParser::parsePropellerID(Optional<unsigned> &PrID) {
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100808/new/

https://reviews.llvm.org/D100808