[PATCH] D107953: [Flang] test_symbols.py module file fix
Andrzej Warzynski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 16 02:31:33 PDT 2021
awarzynski added a comment.
In D107953#2944145 <https://reviews.llvm.org/D107953#2944145>, @Meinersbur wrote:
> `%t` expands to `<builddir>/tools/flang/test/<filename>.tmp`. That is, it is unique for every test file, but that same for multiple `RUN` lines in the file and between `make check` invocations. However, I think it is better to always have a fresh temporary directory, `flang-new` does not need to see the leftover files from the previous `make check` run, those should be independent.
+1 for this approach, thank you for the suggestion!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107953/new/
https://reviews.llvm.org/D107953
More information about the llvm-commits
mailing list