[PATCH] D108101: [M68k] Do not pass llvm::Function reference to M68kCCState

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 02:12:45 PDT 2021


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

Thanks for looking at this!

LGTM, with the clang-format fix and (possibly) the const ref fix.



================
Comment at: llvm/lib/Target/M68k/M68kCallingConv.h:41
                                     ISD::ArgFlagsTy &ArgFlags, CCState &State) {
   M68kCCState CCInfo = static_cast<M68kCCState &>(State);
 
----------------
(semi off topic) - should this be 'const M68kCCState &CCInfo' ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108101/new/

https://reviews.llvm.org/D108101



More information about the llvm-commits mailing list