[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:626-632
+      if (AI->isFloatingPointOperation())
+        emitAtomicExpansionRemarks(
+            AI, Kind,
+            Remark << "A hardware CAS loop generated: if the memory is "
+                      "known to be coarse-grain allocated then a hardware "
+                      "floating-point"
+                      " atomic could be requested");
----------------
This is an AMDGPU specific message/restriction. The floating point operation isn't relevant, and you don't even know the specific reason at this point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891