[PATCH] D106947: [DSE][NFC] Rename Later->Killing, Earlier->Killed

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 15 22:40:27 PDT 2021


ebrevnov added a comment.

In D106947#2943272 <https://reviews.llvm.org/D106947#2943272>, @fhahn wrote:

> Hm, the current names are not great, but at least for some functions, we are not sure yet if the passed in instructions actually 'kill' the earlier one, so using `Killed/Killing` may be a bit confusing in its own right?

English is not my native language so I may be mistaken. Google translate gives "killed" for adverb with the meaning of not yet completed action. Maybe there is another form for that?
Even though I like Killing/Killed pair more than Earlier/Later that's not the biggest deal. Biggest problem for me is inconsistency in naming. Sometimes It is hard to follow what is what. So I can go with Earlier/Later taken it is used consistently across source code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106947/new/

https://reviews.llvm.org/D106947



More information about the llvm-commits mailing list