[PATCH] D108019: [NFC][llvm-xray] add a llvm-xray convert option `symbolize-no-demangle`

Sun Aug 15 20:31:15 PDT 2021

MaskRay added a comment.

In D108019#2945958 <https://reviews.llvm.org/D108019#2945958>, @Enna1 wrote:

> In D108019#2945953 <https://reviews.llvm.org/D108019#2945953>, @MaskRay wrote:
>
>> Perhaps switch to no-demangle by default and add `--symbolize-demangle`?
>
> We should provide a consistent naming with `llvm-xray extract` ? `llvm-xray extract` use an option `no-demangle` and set `no-demangle` to false on default.

Now I have taken a closer look. `--no-demangle` from `extract` can be shared with `convert`. `--symbolize` is similarly used by both commands.

> Changing the default behavior may break current usages. It's not a good choice. Perhaps we can leave this choice to the future.

`function` was a late addition. `--no-demangle` was added to `extract`. Now there is a request for `convert`.
This made we wonder whether demangle is a good default choice.
Changing the default should not be taken lightly, but I'd not say such change is blocked because some users can be reluctant to change.

I'm going to add `--demangle` first.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108019/new/

https://reviews.llvm.org/D108019