[PATCH] D108093: [X86] Support avx512fp16 compare instructions in the IntelInstPrinter.

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 15 18:10:25 PDT 2021


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks Craig for fixing it.



================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86ATTInstPrinter.cpp:204-208
+              (Desc.TSFlags & X86II::OpPrefixMask) == X86II::XS)
+            printwordmem(MI, CurOp--, OS);
+          else if ((Desc.TSFlags & X86II::OpMapMask) == X86II::TA &&
+                   (Desc.TSFlags & X86II::OpPrefixMask) == X86II::XD)
+            llvm_unreachable("Unexpected op prefix!");
----------------
Why don't use assert like above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108093/new/

https://reviews.llvm.org/D108093



More information about the llvm-commits mailing list