[PATCH] D102817: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 2

Ten Tzen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 15 00:37:32 PDT 2021


tentzen added inline comments.


================
Comment at: llvm/lib/Analysis/EHPersonalities.cpp:82-83
+  const llvm::Module *M = (const llvm::Module *)F->getParent();
+  bool EHa = M->getModuleFlag("eh-asynch");
+  return !isAsynchronousEHPersonality(Personality) && !EHa;
 }
----------------
gAlfonso-bit wrote:
> I would check for EHA first before checking if the personality is Asynchronous
OK, make sense. will do.
thank you for the feedback!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102817/new/

https://reviews.llvm.org/D102817



More information about the llvm-commits mailing list