[compiler-rt] c35e4dc - [asan][test] Un-xfail Posix/unpoison-alternate-stack.cpp on Solaris again

Rainer Orth via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 15 00:21:50 PDT 2021


Author: Rainer Orth
Date: 2021-08-15T09:21:08+02:00
New Revision: c35e4dc8dd0b9d4e53633962670d70832fa383c8

URL: https://github.com/llvm/llvm-project/commit/c35e4dc8dd0b9d4e53633962670d70832fa383c8
DIFF: https://github.com/llvm/llvm-project/commit/c35e4dc8dd0b9d4e53633962670d70832fa383c8.diff

LOG: [asan][test] Un-xfail Posix/unpoison-alternate-stack.cpp on Solaris again

`Posix/unpoison-alternate-stack.cpp` currently `XPASS`es on Solaris.  The
`XFAIL` had already been removed in D97933
<https://reviews.llvm.org/D97933>, but reintroduced by commit
f03d29601e0951da2c88f07d4234128e14e87870
<https://reviews.llvm.org/rGf03d29601e0951da2c88f07d4234128e14e87870> which
was never posted or justified.

Given the `XPASS`, this obviously wasn't NFC, so I suggest to remove it again.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.

Differential Revision: https://reviews.llvm.org/D108030

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp b/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
index a2082ed082154..50d28ddf84c2f 100644
--- a/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
@@ -6,9 +6,6 @@
 // RUN: %clangxx_asan -std=c++20 -fexceptions -O0 %s -o %t -pthread
 // RUN: %run %t
 
-// longjmp from signal handler is unportable.
-// XFAIL: solaris
-
 #include <algorithm>
 #include <cassert>
 #include <cerrno>


        


More information about the llvm-commits mailing list