[PATCH] D107988: [Linker] Import IFuncs

[Fangrui Song via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG530aa7e4da14: [Linker] Import GlobalIFunc when importing symbols from another module (authored by nextsilicon-itay-bookstein, committed by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107988/new/

https://reviews.llvm.org/D107988

Files:
  llvm/lib/Linker/LinkModules.cpp
  llvm/test/Linker/ifunc.ll


Index: llvm/test/Linker/ifunc.ll
===================================================================
--- /dev/null
+++ llvm/test/Linker/ifunc.ll
@@ -0,0 +1,25 @@
+; RUN: split-file %s %t
+; RUN: llvm-link %t/a.ll %t/b.ll -S -o - | FileCheck %s
+
+;; Check that ifuncs are linked in properly.
+
+; CHECK-DAG: @foo = ifunc void (), bitcast (void ()* ()* @foo_resolve to void ()*)
+; CHECK-DAG: define internal void ()* @foo_resolve() {
+
+; CHECK-DAG: @bar = ifunc void (), bitcast (void ()* ()* @bar_resolve to void ()*)
+; CHECK-DAG: define internal void ()* @bar_resolve() {
+
+;--- a.ll
+declare void @bar()
+
+;--- b.ll
+ at foo = ifunc void (), bitcast (void ()* ()* @foo_resolve to void ()*)
+ at bar = ifunc void (), bitcast (void ()* ()* @bar_resolve to void ()*)
+
+define internal void ()* @foo_resolve() {
+  ret void ()* null
+}
+
+define internal void ()* @bar_resolve() {
+  ret void ()* null
+}
Index: llvm/lib/Linker/LinkModules.cpp
===================================================================
--- llvm/lib/Linker/LinkModules.cpp
+++ llvm/lib/Linker/LinkModules.cpp
@@ -526,6 +526,10 @@
     if (linkIfNeeded(GA))
       return true;
 
+  for (GlobalIFunc &GI : SrcM->ifuncs())
+    if (linkIfNeeded(GI))
+      return true;
+
   for (unsigned I = 0; I < ValuesToLink.size(); ++I) {
     GlobalValue *GV = ValuesToLink[I];
     const Comdat *SC = GV->getComdat();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107988.366474.patch
Type: text/x-patch
Size: 1380 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210815/25d5ee7f/attachment.bin>