[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1121
+      // Set FSProfileFile so that CodeGen can read the profile.
+      FSProfileFile.setValue(PGOOpt->ProfileFile);
+    }
----------------
xur wrote:
> hoy wrote:
> > Can this be moved into the constructor of `PGOOptions` so that it looks more consistent with the rest of PGO setup?
> Do you mean we still using FSProfileFile but just move the assignment to PGOOptions constructor? This should do doable.
Yes, that's what I meant. Currently `FSProfileFile` is set in postlink for LTO. It shouldn't matter if it is always set, since no prelink pass consumes that now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878