[PATCH] D108031: [test] Avoid unportable echo in Other/lit-quoting.txt

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

> ... as extensively documented in the Autoconf manual ...

I hope I never have the joy of reading it. :)

In D108031#2944321 <https://reviews.llvm.org/D108031#2944321>, @mstorsjo wrote:

> I'm surprised to see that this actually seems to pass in the Windows CI environment (even if there are plenty of other unrelated failures in the CI run). On Windows, these tests aren't executed by a unix shell, but by the python lit internal shell, and `echo` is one of the commands handled internally there, but `printf` isn't.

So, if I understand, the printf variant is actually a *better* test than the echo test because lit will actually call out to an external program. At least, I do believe this version does test the codepath that we care about, right? If you agree, I think this is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108031/new/

https://reviews.llvm.org/D108031