[PATCH] D108002: [llvm-profgen] Clean up code dealing with multiple binaries
Hongtao Yu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 13 12:56:05 PDT 2021
hoy accepted this revision.
hoy added a comment.
This revision is now accepted and ready to land.
lgtm except for a minor issue.
================
Comment at: llvm/tools/llvm-profgen/PerfReader.cpp:350
- if (Event.Offset == Binary.getTextSegmentOffset()) {
- // A binary image could be unloaded and then reloaded at different
- // place, so update the address map here.
----------------
The comment could still be helpful?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108002/new/
https://reviews.llvm.org/D108002
More information about the llvm-commits
mailing list