[PATCH] D108048: [DependenceAnalysis] Conservatively exit on type mismatch

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/lib/Analysis/DependenceAnalysis.cpp:3494-3498
+    /// depends - Tests for a dependence between the Src and Dst instructions.
+    /// Returns NULL if no dependence; otherwise, returns a Dependence (or a
+    /// FullDependence) with as much information as can be gleaned.
+    /// If PossiblyLoopIndependant is true will also test for intra-iteration 
+    /// dependencies.
----------------
Did you intend to replace the non-doxygen comment for `depends`?


================
Comment at: llvm/lib/Analysis/DependenceAnalysis.cpp:3594
+
+  auto &DL = F->getParent()->getDataLayout();
+  bool ModifiedGEPOp =
----------------
Please consider the LLVM coding style for use of `auto`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108048/new/

https://reviews.llvm.org/D108048