[PATCH] D108002: [llvm-profgen] Clean up code dealing with multiple binaries

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 13 10:41:17 PDT 2021


hoy added a comment.

Thanks for the cleanup. The new code looks cleaner and I believe it'll also speed up the tool.



================
Comment at: llvm/tools/llvm-profgen/PerfReader.h:535
 // Address to binary map for fast look-up
 using AddressBinaryMap = std::map<uint64_t, ProfiledBinary *>;
 
----------------
Do we still need this? Looks like this can be just a single field of `PerfReaderBase`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108002/new/

https://reviews.llvm.org/D108002



More information about the llvm-commits mailing list