[PATCH] D108044: [scudo] Correct format string specifiers

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 13 10:26:55 PDT 2021


cryptoad updated this revision to Diff 366308.
cryptoad added a comment.

So this turned out to be a little more complicated for 32-b.
The 'z' format specifier expects a `size_t` which is defined
as a `unsigned int` on 32-b Linux platforms, while our
`scudo::uptr` are defined a `unsigned long`. So `zu` wasn't
an appropriate specifier on 32-b platforms for a `uptr`.

This introduces a 'l' format specifier that we didn't previously
have, and replaces 'z' with 'l' for all `uptr` format strings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108044/new/

https://reviews.llvm.org/D108044

Files:
  compiler-rt/lib/scudo/standalone/CMakeLists.txt
  compiler-rt/lib/scudo/standalone/common.cpp
  compiler-rt/lib/scudo/standalone/primary32.h
  compiler-rt/lib/scudo/standalone/primary64.h
  compiler-rt/lib/scudo/standalone/quarantine.h
  compiler-rt/lib/scudo/standalone/report.cpp
  compiler-rt/lib/scudo/standalone/secondary.h
  compiler-rt/lib/scudo/standalone/size_class_map.h
  compiler-rt/lib/scudo/standalone/string_utils.cpp
  compiler-rt/lib/scudo/standalone/tests/CMakeLists.txt
  compiler-rt/lib/scudo/standalone/tests/strings_test.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108044.366308.patch
Type: text/x-patch
Size: 14882 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210813/b325d737/attachment.bin>


More information about the llvm-commits mailing list