[PATCH] D108016: [lld-macho] Ignore LLVM segments to prevent duplicate syms

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 13 09:45:01 PDT 2021


oontvoo added inline comments.


================
Comment at: lld/test/MachO/ignore-symbols.s:11-17
+.globl _llvm.foo
+.section __LLVM,__bitcode
+_llvm.foo:
+.asciz "test"
+
+#--- bar.s
+.globl _llvm.foo
----------------
How does ld64 deal with this, though? (quick glance at the code, I didn't see any special handling for _llvm segments)

Just concerned that this change is hiding a bug somewhere else


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108016/new/

https://reviews.llvm.org/D108016



More information about the llvm-commits mailing list