[PATCH] D108028: [LoopVectorize] Don't emit remarks about lack of scalable vectors unless they're specifically requested.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 13 09:44:55 PDT 2021
fhahn accepted this revision.
fhahn added a comment.
LGTM, thanks! IMO it makes sense to limit the message to cases where scalable vectorization was requested but not possible. It might be good to add a brief description in the commit message.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5718
+ << " is ignored because the target does not support scalable "
+ "vectors. The Compiler will pick a suitable VF.";
+ });
----------------
nit: `compiler`?
Spelling out `VF` as vectorization factor or something like that would probably help to make the remark easier to understand for users.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108028/new/
https://reviews.llvm.org/D108028
More information about the llvm-commits
mailing list