[PATCH] D108022: [AMDGPU] Skip pseudo MIs in hazard recognizer

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 13 08:14:39 PDT 2021


arsenm added a comment.

In D108022#2943806 <https://reviews.llvm.org/D108022#2943806>, @cdevadas wrote:

> In D108022#2943730 <https://reviews.llvm.org/D108022#2943730>, @arsenm wrote:
>
>> I think you're missing the check in AdvanceCycle
>
> There was a call to getNumWaitStates in AdvanceCycle. I presumed a zero waitstate here is equivalent to an early return.
> Isn't it?
> https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp#L365

I think the early return on isMetaInstruction avoids pushing the instruction into EmittedInstrs


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108022/new/

https://reviews.llvm.org/D108022



More information about the llvm-commits mailing list