[PATCH] D107964: [LoopIdiom] Don't transform loop into memmove when load from body has more than one use

[Dawid Jurczak via Phabricator via llvm-commits]

yurai007 added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1314
+                            StoreSizeSCEV, *AA, Stores) ||
+      (UseMemMove && !TheLoad->hasOneUse())) {
     ORE.emit([&]() {
----------------
efriedma wrote:
> I think this belongs earlier, with the other mayLoopAccessLocation check?  It's basically a variation of the same check.
Reffering to my previous comment - if you mean just moving this check before mayLoopAccessLocation then yes, I agree and you may ignore what I said about AA there :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107964/new/

https://reviews.llvm.org/D107964