[PATCH] D108030: [asan][test] Un-xfail Posix/unpoison-alternate-stack.cpp on Solaris again

Rainer Orth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 13 05:57:33 PDT 2021


ro created this revision.
ro added a reviewer: vitalybuka.
ro added a project: Sanitizers.
Herald added subscribers: pengfei, fedor.sergeev.
ro requested review of this revision.
Herald added a subscriber: Sanitizers.

`Posix/unpoison-alternate-stack.cpp` currently `XPASS`es on Solaris.  The `XFAIL` had
already been removed in D97933 <https://reviews.llvm.org/D97933>, but reintroduced by commit f03d29601e0951da2c88f07d4234128e14e87870 <https://reviews.llvm.org/rGf03d29601e0951da2c88f07d4234128e14e87870> which was never posted or justified.

Given the `XPASS`, this obviously wasn't NFC, so I suggest to remove it again.

Tested on `amd64-pc-solaris2.11` and `x86_64-pc-linux-gnu`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108030

Files:
  compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp


Index: compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
===================================================================
--- compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
+++ compiler-rt/test/asan/TestCases/Posix/unpoison-alternate-stack.cpp
@@ -6,9 +6,6 @@
 // RUN: %clangxx_asan -std=c++20 -fexceptions -O0 %s -o %t -pthread
 // RUN: %run %t
 
-// longjmp from signal handler is unportable.
-// XFAIL: solaris
-
 #include <algorithm>
 #include <cassert>
 #include <cerrno>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108030.366258.patch
Type: text/x-patch
Size: 517 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210813/e2c27a25/attachment.bin>


More information about the llvm-commits mailing list