[PATCH] D101446: [llvm] Improve export.sh with help and snapshot

[Konrad Wilhelm Kleine via Phabricator via llvm-commits]

kwk added inline comments.


================
Comment at: llvm/utils/release/export.sh:85
+    # Determine the release by fetching the version from LLVM's CMakeLists.txt.
+    [ -n "$snapshot" ] && release=$(grep -ioP 'set\(\s*LLVM_VERSION_(MAJOR|MINOR|PATCH)\s\K[0-9]+' $llvm_src_dir/llvm/CMakeLists.txt | paste -sd '.')
+    
----------------
tstellar wrote:
> This is getting the release version from the LLVM source that contains export.sh, but it should be getting the version from the source that will be packaged.
Oh boy, that's a very good catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101446/new/

https://reviews.llvm.org/D101446