[PATCH] D107034: [CSPGO] Set EnableValueProfiling flag for CSPGO to avoid IRPGO value loss in LTO

Fri Aug 13 02:48:33 PDT 2021

YolandaCY marked an inline comment as done.
YolandaCY added inline comments.

================
Comment at: llvm/lib/LTO/LTO.cpp:1236
+      if (isIRPGOFlagSet(&M))
+        M.addModuleFlag(llvm::Module::Warning, "EnableValueProfiling", 1);
+
----------------
rnk wrote:
> My only concern is that we have to do this in two places. Is there a better place we can do this? Maybe the frontend, or wherever we enable IR PGO? These feel like the wrong places.
Thank you Reid for the suggestion. Agree that setting this ealier when we enable the IR PGO is better. Revised the patch accordingly.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107034/new/

https://reviews.llvm.org/D107034