[PATCH] D107902: [AArch64][SME] Disable NEON on generic CPU for streaming mode

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 13 01:04:39 PDT 2021


david-arm added inline comments.


================
Comment at: llvm/test/MC/AArch64/SME/feature.s:13
+
+// Most of the NEON instruction set is illegal in streaming mode. If no CPU is
+// specified the default is generic which implies NEON, but if streaming-sve
----------------
nit: This comment is a little confusing to be honest! Particularly the bit that says "if streaming-sve (..) is enabled it's disabled". How about something like:

  If no CPU is specified the default is generic which implies NEON. However, in streaming-sve mode
  NEON is disabled by default, unless the user has explicitly added the feature.

Or something similar?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107902/new/

https://reviews.llvm.org/D107902



More information about the llvm-commits mailing list