[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/CodeGen/FlowSensitiveSampleProfile.cpp:34
+                           cl::init(false),
+                           cl::desc("Disable flow senstive profile loading"));
+static cl::opt<bool> EnableFSBranchProb(
----------------
typo: senstive


================
Comment at: llvm/lib/CodeGen/FlowSensitiveSampleProfile.cpp:35
+                           cl::desc("Disable flow senstive profile loading"));
+static cl::opt<bool> EnableFSBranchProb(
+    "enable-fs-branchprob", cl::Hidden, cl::init(true),
----------------
Wondering why needs this switch. The whole point of `FSProfileLoader` is to overwrite branch weights?


================
Comment at: llvm/lib/Passes/PassBuilder.cpp:1121
+      // Set FSProfileFile so that CodeGen can read the profile.
+      FSProfileFile.setValue(PGOOpt->ProfileFile);
+    }
----------------
Can this be moved into the constructor of `PGOOptions` so that it looks more consistent with the rest of PGO setup?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107878/new/

https://reviews.llvm.org/D107878