[PATCH] D107914: [PowerPC] Disable CTR Loop generate for fma with the PPC double double type.

[ChenZheng via Phabricator via llvm-commits]

shchenz accepted this revision.
shchenz added a comment.
This revision is now accepted and ready to land.

Look good to me except for some minor comments for the test cases part.



================
Comment at: llvm/test/CodeGen/PowerPC/disable-ctr-ppcf128.ll:16
+
+$test_ctr0 = comdat any
+
----------------
Is it necessary to test we don't generate a CTR loop?


================
Comment at: llvm/test/CodeGen/PowerPC/disable-ctr-ppcf128.ll:21
+
+define linkonce_odr hidden ppc_fp128 @test_ctr0(i32 %arg, i32 %arg1, %0* %arg3, %0* %arg4) local_unnamed_addr #0 comdat {
+; LE-LABEL: test_ctr0:
----------------
none of these args are used in the function body, so I think they can be removed and the type definition for %0, %1, %2, %3 can also be removed?


================
Comment at: llvm/test/CodeGen/PowerPC/disable-ctr-ppcf128.ll:21
+
+define linkonce_odr hidden ppc_fp128 @test_ctr0(i32 %arg, i32 %arg1, %0* %arg3, %0* %arg4) local_unnamed_addr #0 comdat {
+; LE-LABEL: test_ctr0:
----------------
shchenz wrote:
> none of these args are used in the function body, so I think they can be removed and the type definition for %0, %1, %2, %3 can also be removed?
We can also removed the unnecessary function attributes like `linkonce_odr` `hidden` `local_unnamed_addr` and `local_unnamed_addr`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107914/new/

https://reviews.llvm.org/D107914