[PATCH] D107996: [libunwind] Rename UNW_ARM64_* to UNW_AARCH64_*

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 12 21:34:25 PDT 2021


mstorsjo added a comment.

> Not sure keeping UNW_ARM64_* has any compatibility importance.

There’s code using the llvm version of libunwind that expects these names, see e.g. https://source.winehq.org/git/wine.git/blob/6b58d34a625ffaad181a7316009398f3c6444181:/dlls/ntdll/unix/signal_arm64.c#l250.

(Also, the same file, on lines 188-208, has a different codepath for setting registers with llvm’s libunwind, iirc because our context is opaque. The corresponding file for x86_64 also has that distinction, even if the enum names match there.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107996/new/

https://reviews.llvm.org/D107996



More information about the llvm-commits mailing list